Skip to content

Implement function to verify index signature with custom key #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 3, 2021
Merged

Implement function to verify index signature with custom key #1304

merged 5 commits into from
Jun 3, 2021

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Jun 1, 2021 •
edited
Loading

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

feature

  • What is the current behavior?

There is no way of specifying another gpg public key to verify if the signature of an index is correct.

  • What is the new behavior?
  • Added a new gpg public key in order to verify the signature of module_firmware_index.json
  • Added VerifyDetachedSignature function that allows to specify the path of another gpg public key
  • Added new tests and enhanced a bit the existing ones
  • Does this PR introduce a breaking change, and is
    titled accordingly?

nope

  • Other information:

See how to contribute

@umbynos umbynos added the topic: code Related to content of the project itself label Jun 1, 2021
@umbynos umbynos requested a review from cmaglie June 1, 2021 14:39
@umbynos umbynos self-assigned this Jun 1, 2021
cmaglie
cmaglie approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@cmaglie cmaglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nitpick.
For the rest looks good 👍🏼

@umbynos umbynos changed the title Add board signature key Add module_firmware_index signature key and implement function to verify signature with custom key Jun 1, 2021
@umbynos umbynos changed the title Add module_firmware_index signature key and implement function to verify signature with custom key Implement function to verify index signature with custom key Jun 3, 2021
@umbynos umbynos merged commit 7eb9c57 into master Jun 3, 2021
@umbynos umbynos deleted the umbynos/add_board_signature_key branch June 3, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

Assignees

@umbynos umbynos

Labels
topic: code Related to content of the project itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@umbynos @cmaglie